Skip to content

Conversation

@ramonsmits
Copy link
Member

@ramonsmits ramonsmits commented Feb 8, 2025

  • Code analysis of Raven.Embedded/EmbeddedServer.cs shows that during dispose the routine waits for the duration in GracefulShutdownTimeout and after that it should kill the process
  • We cancelled host stop after 30 seconds explicitly on master, changed this to 5 minutes to allow child ravendb process to flush its data
  • On master ShutdownTimeout and GracefulShutdownTimeout are the same. This will likely always result in the host already cancelling and exiting before Raven.Embedded/EmbeddedServer.cs its dispose will kill the child process. Therefore GracefulShutdownTimeout is reduced by 5 seconds. This likely will result in that dispose to actually kill the child process.
  • That could still fail but hopefully this will now be logged as this PR enabled file and console logging of RavenDB embedded client
  • By ramping up the ShutdownTimeout to 5 minutes it hopefully allows the installer during an upgrade to finish loading and unloading the RavenDB child process

@ramonsmits
Copy link
Member Author

Closing as this was used for analysis and discussion

@ramonsmits ramonsmits closed this Mar 11, 2025
@bording bording deleted the ravendb-exit branch April 28, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants